This repository was archived by the owner on May 12, 2026. It is now read-only.
docs: add documentation for Builder class in IdTokenCredentials - #1840
Closed
diegomarquezp wants to merge 2 commits into
Closed
docs: add documentation for Builder class in IdTokenCredentials#1840diegomarquezp wants to merge 2 commits into
diegomarquezp wants to merge 2 commits into
Conversation
diegomarquezp
marked this pull request as ready for review
November 6, 2025 18:32
|
lqiu96
reviewed
Dec 9, 2025
| return new Builder(); | ||
| } | ||
|
|
||
| /** Builder of IdTokenCredentials. For usage and examples, see {@link IdTokenCredentials} */ |
Member
There was a problem hiding this comment.
Hey sorry, I just noticed this PR. I don't think this change actually address the feedback from the ticket.
We should add javadocs for:
- setIdTokenProvider - This cannot be set to null
- setTargetAudience - should not be set for userCredentials as targetAudience cannot be set for UserCredentials. For other credentials, this cannot be null.
Additionally, it looks like setOptions can be null, though I think we probably should check for nullness here as well
Member
|
closing in favor of #1909 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/414071824