build(cmake): update clang tidy property for NO_WARNINGS - #16281
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in cmake/GoogleCloudCppCommonOptions.cmake by replacing the undefined or incorrect variable ${libname} with the function parameter ${target} when setting target properties for disabling clang-tidy warnings. There are no review comments, and I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16281 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 2223 2223
Lines 207876 207876
=======================================
+ Hits 191876 191883 +7
+ Misses 16000 15993 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a larger change, but isolated in its own PR. It should not change existing behavior...