docs(bigquery): add QueryArrow code sample and document JDK 17+ JVM requirements - #14437
jinseopkim0 wants to merge 2 commits into
Conversation
|
@gemini-code-assist review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new code sample, QueryArrow.java, along with its integration tests, demonstrating how to stream Apache Arrow VectorSchemaRoot batches directly using BigQuery. It also updates the README and adds Javadoc documentation to the BigQuery interface detailing the JVM requirements (Java 16+) for Apache Arrow's memory allocator. Feedback on the changes suggests avoiding swallowing InterruptedException in the new sample and instead restoring the thread's interrupted status.
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request adds a new code sample, QueryArrow.java, along with its integration test and README documentation, demonstrating how to query BigQuery and stream Apache Arrow VectorSchemaRoot batches. It also updates the Javadoc in BigQuery.java to document the JVM requirements for running Apache Arrow on Java 16+. Feedback on the new sample suggests properly handling InterruptedException by restoring the thread's interrupted status instead of swallowing it.
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new code sample, QueryArrow.java, along with its integration test, QueryArrowIT.java, demonstrating how to query BigQuery and stream Apache Arrow vectors. It also updates the README.md to document the new sample and adds Javadoc warnings to the BigQuery interface explaining the JVM options required for Apache Arrow on Java 16+. There are no review comments to address, and I have no further feedback to provide.
There was a problem hiding this comment.
Code Review
This pull request introduces a new code sample, QueryArrow.java, and its corresponding integration test, QueryArrowIT.java, demonstrating how to execute queries and stream Apache Arrow VectorSchemaRoot batches. It also updates the README.md to document the new sample and adds Javadoc to the BigQuery interface detailing the JVM arguments required for Apache Arrow on Java 16+. There are no review comments, and I have no feedback to provide.
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request adds a new code sample, QueryArrow.java, and its corresponding integration test, QueryArrowIT.java, to demonstrate querying BigQuery and streaming Apache Arrow VectorSchemaRoot batches. Additionally, it updates the README.md to document the new sample and adds Javadoc comments to BigQuery.java explaining the JVM requirements (specifically the --add-opens option) when using Apache Arrow on Java 16+. There are no review comments, and I have no feedback to provide.
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
1 participant
Adds a QueryArrow code sample demonstrating zero-copy VectorSchemaRoot streaming with try-with-resources. Also documents the required --add-opens JVM flag in queryArrow Javadoc for applications running on JDK 17+.