chore(bigtable): reorganize samples - #17819
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request restructures the samples directory of the google-cloud-bigtable package, organizing samples into subdirectories such as admin_client, data_client_async, and legacy_client. This restructuring is reflected in updates to integration configurations, documentation configuration, and contributing guidelines. I have no feedback to provide.
|
Done. Please merge main into this branch |
|
@daniel-sanche We also need the fix in #17909. Please can you merge main into this branch again? |
| packages/google-cloud-bigtable/samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_update_schema_bundle_sync.py, | ||
| packages/google-cloud-bigtable/samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_update_table_async.py, | ||
| packages/google-cloud-bigtable/samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_update_table_sync.py, | ||
| packages/google-cloud-bigtable/samples/admin_client/generated_samples/bigtableadmin_v2_generated_bigtable_instance_admin_create_app_profile_async.py, |
There was a problem hiding this comment.
It's not currently possible to change the directory for auto-generated samples. The output directory is hard-coded in gapic-generator as "samples/generated_samples"Can you propose a change to gapic-generator to add an option to customize the location?
2 participants
This PR re-organizes the sampes directory, to group files by client.
The change is easier to view by browsing the directory, rather than reading the diff: https://github.com/googleapis/google-cloud-python/tree/samples_1_reorganize_samples/packages/google-cloud-bigtable/samples