chore(test): improve diff detection for unit tests - #17998
Open
daniel-sanche wants to merge 7 commits into
Open
Conversation
Adds a **Related Libraries** table to the `google-cloud-bigquery` [README.rst](file:///usr/local/google/home/shuowei/src/google-cloud-python/google-cloud-python/packages/google-cloud-bigquery/README.rst) linking connector libraries for DataFrame operations: - **BigQuery DataFrames (`bigframes`)**: pandas/scikit-learn-like API powered by BigQuery engine. - **`pandas-gbq`**: integration for loading and writing pandas DataFrames. Fixes #<522853190> 🦕
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates CI scripts to use triple-dot diffs when comparing against the target branch in presubmits, adds support for a pre-determined package list in coverage reporting, and outputs a space-separated list of packages to GitHub Actions output. Feedback was provided to replace --deepen=200 with --depth=200 in ci/run_conditional_tests.sh to avoid potential failures on non-shallow repositories.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff logic in the new unit test sharding system had an issue: when comparing against main to find the modified packages, any packages that changed on main would be treated as packages that changed in the PR
This could especially cause issues if a commit was added while a workflow was running, because the changed package list would shift mid-run
This PR fixes the issue by:
...and a depth of 200 to find the common ancestor commit to diff against, instead of diffing against main directly