Skip to content

chore: use all valid dependency envars in core_deps checks #18392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-sanche wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: use all valid dependency envars in core_deps checks #18392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53f13e7
update noxfile template
daniel-sanche Sep 16, 2026
83a0eb6
update goldens
daniel-sanche Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/gapic-generator/gapic/templates/noxfile.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,11 @@ def prerelease_deps(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down Expand Up @@ -597,7 +601,11 @@ def core_deps_from_source(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down
12 changes: 10 additions & 2 deletions packages/gapic-generator/tests/integration/goldens/asset/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,11 @@ def prerelease_deps(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down Expand Up @@ -589,7 +593,11 @@ def core_deps_from_source(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down
12 changes: 10 additions & 2 deletions packages/gapic-generator/tests/integration/goldens/credentials/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,11 @@ def prerelease_deps(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down Expand Up @@ -589,7 +593,11 @@ def core_deps_from_source(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down
12 changes: 10 additions & 2 deletions packages/gapic-generator/tests/integration/goldens/eventarc/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,11 @@ def prerelease_deps(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down Expand Up @@ -589,7 +593,11 @@ def core_deps_from_source(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down
12 changes: 10 additions & 2 deletions packages/gapic-generator/tests/integration/goldens/logging/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,11 @@ def prerelease_deps(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down Expand Up @@ -589,7 +593,11 @@ def core_deps_from_source(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down
12 changes: 10 additions & 2 deletions packages/gapic-generator/tests/integration/goldens/logging_internal/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,11 @@ def prerelease_deps(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down Expand Up @@ -589,7 +593,11 @@ def core_deps_from_source(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down
12 changes: 10 additions & 2 deletions packages/gapic-generator/tests/integration/goldens/redis/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,11 @@ def prerelease_deps(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down Expand Up @@ -589,7 +593,11 @@ def core_deps_from_source(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down
12 changes: 10 additions & 2 deletions packages/gapic-generator/tests/integration/goldens/redis_selective/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,11 @@ def prerelease_deps(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down Expand Up @@ -589,7 +593,11 @@ def core_deps_from_source(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down
12 changes: 10 additions & 2 deletions packages/gapic-generator/tests/integration/goldens/storagebatchoperations/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,11 @@ def prerelease_deps(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down Expand Up @@ -589,7 +593,11 @@ def core_deps_from_source(session, protobuf_implementation):
session.install("-e", ".")

# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
unit_deps_all = (
UNIT_TEST_STANDARD_DEPENDENCIES
+ UNIT_TEST_DEPENDENCIES
+ UNIT_TEST_EXTERNAL_DEPENDENCIES
)
session.install(*unit_deps_all)

# Because we test minimum dependency versions on the minimum Python
Expand Down
Loading