fix: update librarian to v0.39.1-0.20260831182628-509cd77c2487 - #36486
Merged
Conversation
suztomo
force-pushed
the
chore/update-librarian-version
branch
from
August 31, 2026 19:40
754bf2d to
f31681b
Compare
suztomo
marked this pull request as ready for review
August 31, 2026 19:44
aandreassa
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Librarian to
v0.39.1-0.20260831182628-509cd77c2487(incorporating googleapis/librarian#7455 to respectall: restin sdk.yaml) and regenerates all libraries withlibrarian generate --all.This update respects REST-only transport configurations in
sdk.yamlby passing only--ruby_outto protoc and omitting--grpc_outand--plugin=protoc-gen-grpc, removing unnecessary*_services_pb.rbstub files from pure REST libraries.Note that the discrepancy between
transports: ... restconfigurations and generating/committing*_services_pb.rbfiles had already started before Librarian migration under OwlBot generation. For example,lib/google/ads/admanager/v1/ad_break_service_services_pb.rbingoogle-ads-ad_manager-v1was originally introduced in commit ef7575eaf7f6cf8d975c0f7af2040fe85b0e4cf0 (Date: Tue Jul 8 14:24:06 2025 -0700, PR #30579) by OwlBot, even though Ad Manager is a pure REST client.Finding in Legacy Bazel Files
In the legacy Bazel pipeline:
ruby_cloud_gapic_libraryinBUILD.bazelcorrectly hadtransport = "rest", sogapic-generator-rubyonly generated REST GAPIC client code.ruby_gapic_assembly_pkgunconditionally listedruby_grpc_library(:admanager_ruby_grpc) in itsdeps._ruby_gapic_assembly_pkg_implinrules_ruby_gapic/ruby_gapic_pkg.bzlunpacked alldeps(including gRPC stubs fromruby_grpc_library) into the output archive/libdirectory.google-cloud-ruby.SemVer / Commit Prefix
The removal of these unused stub classes is tentatively set to
fix:(no breaking change) because the underlying services have not supported gRPC and the generated GAPIC clients for these libraries have always operated over REST only.Affected Gems
google-ads-ad_manager-v1: Removed 62 obsolete*_services_pb.rbservice stubs.google-cloud-api_hub-v1: Removed 9 obsolete*_services_pb.rbservice stubs.google-cloud-ftp-v1: Removed 1 obsolete*_services_pb.rbservice stub.google-cloud-gke_connect-gateway-v1: Removed 1 obsolete*_services_pb.rbservice stub.google-cloud-gke_connect-gateway-v1beta1: Removed 1 obsolete*_services_pb.rbservice stub.Verification
Local CI checks passed with 0 offenses and 0 failures:
This fix is a step towards googleapis/librarian#7452.
BEGIN_COMMIT_OVERRIDE
fix: update librarian to v0.39.1-0.20260831182628-509cd77c2487 to respect "all: rest"
END_COMMIT_OVERRIDE