feat(collections,clustering): complete Kotlin migration for core modules and apply optimizations - #1766
Open
dkhawk wants to merge 1 commit into
Open
feat(collections,clustering): complete Kotlin migration for core modules and apply optimizations#1766dkhawk wants to merge 1 commit into
dkhawk wants to merge 1 commit into
Conversation
dkhawk
force-pushed
the
chore/lint-fixes
branch
from
August 26, 2026 18:58
cca4a19 to
fce0b17
Compare
dkhawk
force-pushed
the
chore/lint-fixes
branch
from
August 26, 2026 19:04
fce0b17 to
6af4e0c
Compare
Contributor
Code Coverage
Files
|
dkhawk
force-pushed
the
chore/lint-fixes
branch
7 times, most recently
from
August 26, 2026 20:19
3ce9d22 to
47e2e74
Compare
Collaborator
|
It seems that this got lost during a merge or rebase on the big refactor branch. The |
…les and apply optimizations
dkhawk
force-pushed
the
chore/lint-fixes
branch
from
August 27, 2026 21:34
47e2e74 to
7155097
Compare
Contributor
Author
|
Thank you for the review, @kikoso! The shared boilerplate across the 5 collection managers has now been unified into
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:libraryand:datato idiomatic, safe Kotlin (KmlUrlSanitizer,MapObjectManager,MarkerManager,CircleManager,GroundOverlayManager,PolygonManager,PolylineManager,KmlZipBombTest,StaticClusterTest).ClusterManagerlifecycle operations (MapObjectManagerTest,MarkerManagerTest,CircleManagerTest,GroundOverlayManagerTest,PolygonManagerTest,PolylineManagerTest,NonHierarchicalViewBasedAlgorithmTest,ScreenBasedAlgorithmAdapterTest,GridBasedAlgorithmTest,AbstractAlgorithmTest,SphericalMercatorProjectionTest,StaticClusterTest,ClusterManagerTest).!!force-unwraps with safe checks and.also { ... }.`object`) with descriptive parameter names.java.utilcollection instantiations with pure Kotlin collection builders (mutableMapOf(),mutableSetOf()).=).HeatmapTileProvider.ktraster calculations.openmodality modifiers inClusterManager.kt.Verification
./gradlew test lint assemble jacocoTestDebugUnitTestReport— all 265 test tasks, lint checks, and coverage reports succeeded (88.28% coverage on:library, 30.53% on:clustering).Reviewer
cc @LoyalAbbas