xds: Wrap around the ring in RingHashLoadBalancer.getTargetIndex - #13054
Open
TimurRakhmatullin86 wants to merge 1 commit into
Open
xds: Wrap around the ring in RingHashLoadBalancer.getTargetIndex#13054TimurRakhmatullin86 wants to merge 1 commit into
TimurRakhmatullin86 wants to merge 1 commit into
Conversation
RingHashPicker.getTargetIndex binary-searches the Ketama ring for the smallest ring entry whose hash is >= the request hash. When the request hash is greater than every entry on the ring, the search stops at the last entry and returns it instead of wrapping clockwise back to the first entry as a ring requires. As a result, requests whose hash falls in the gap above the largest ring point are routed to the last ring entry's host as the primary pick (and demote the first entry's host), diverging from the affinity Envoy and gRPC C-core produce for the same hash and skewing load onto the last host. That window is a deterministic slice of the 64-bit hash space and is always reachable, since the request hash is an independent 64-bit value. Return index 0 when the request hash exceeds the largest ring entry so the ring wraps around; a hash equal to the largest entry still resolves to that entry (strict comparison). Add a test asserting that a hash above the maximum and a hash below the minimum select the same host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RingHashPicker.getTargetIndex binary-searches the Ketama ring for the smallest ring entry whose hash is >= the request hash. When the request hash is greater than every entry on the ring, the search stops at the last entry and returns it instead of wrapping clockwise back to the first entry as a ring requires.
As a result, requests whose hash falls in the gap above the largest ring point are routed to the last ring entry's host as the primary pick (and demote the first entry's host), diverging from the affinity Envoy and gRPC C-core produce for the same hash and skewing load onto the last host. That window is a deterministic slice of the 64-bit hash space and is always reachable, since the request hash is an independent 64-bit value.
Return index 0 when the request hash exceeds the largest ring entry so the ring wraps around; a hash equal to the largest entry still resolves to that entry (strict comparison). Add a test asserting that a hash above the maximum and a hash below the minimum select the same host.