Added a single variable for the github-handle - #8738
Conversation
… both the github-handle and picture variables
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 8/18/26 7pm |
There was a problem hiding this comment.
The changes are applicable, don't break anything on desktop or mobile from my testing, and clean.
✅ The pull request done with the correct branch
✅ There is a linked issue
✅ Syntax correct according to YAML standard, following instructions precisely from the linked issue: "Do not use a tab to indent github-handle. YAML doesn't allow tabs; it requires spaces."
✅ Affected relevant pages do not break and are clean + consistent in testing (no visual changes)
✅ Other pages are unaffected in testing
Well done @Abigail-Diaz !
|
Review ETA: 8/19/26 7pm |
Tomomi-K1
left a comment
There was a problem hiding this comment.
Nice job @Abigail-Diaz 👍
- it's merging into a correct branch
- update was done according to issue's instruction
- confirmed no visual change on local env
Fixes #7781
What changes did you make?
github-handlevariable for Mya Stark within the existing mappinggithub-handlevariable under the variablenamegithub-handlevariable isnullWhy did you make the changes (we will use this info to test)?
github-handlevariable will eventually replace bothgithubandpicturevariablesCodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
nullto an existing mapping. No visual changes to the website.