Skip to content

Add GitHub handle for joshua bubar 7764 - #8741

Merged
castillios merged 2 commits into
hackforla:gh-pagesfrom
Tomomi-K1:add-github-handle-for-joshua-bubar-7764
Aug 19, 2026
Merged

Add GitHub handle for joshua bubar 7764#8741
castillios merged 2 commits into
hackforla:gh-pagesfrom
Tomomi-K1:add-github-handle-for-joshua-bubar-7764

Conversation

@Tomomi-K1

@Tomomi-K1 Tomomi-K1 commented Aug 19, 2026

Copy link
Copy Markdown
Member

Fixes #7764

What changes did you make?

  • added github-handle: under -name: Joshua Bubar in _projects/new-schools-today.md file.

Why did you make the changes (we will use this info to test)?

  • to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

no visual change

@github-actions

Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Tomomi-K1-add-github-handle-for-joshua-bubar-7764 gh-pages
git pull https://github.com/Tomomi-K1/website.git add-github-handle-for-joshua-bubar-7764

@Tomomi-K1 Tomomi-K1 added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) HLC: C Homepage Launch Countdown Could Have good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 19, 2026
@KyleA99

KyleA99 commented Aug 19, 2026

Copy link
Copy Markdown
Member

Review ETA: 9 PM 8/18/26
Availability: 8-10 PM Today

@KyleA99 KyleA99 self-assigned this Aug 19, 2026
@yielderdev
yielderdev self-requested a review August 19, 2026 04:13
@yielderdev

Copy link
Copy Markdown
Member

Review ETA: 2 PM 8/19
Availability: 11-2 PM 8/19 + intermittently

@KyleA99 KyleA99 removed their assignment Aug 19, 2026
@KyleA99
KyleA99 self-requested a review August 19, 2026 04:33

@KyleA99 KyleA99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tomomi-K1 great job!

  • The pull request is structured correctly
  • The issue is linked in the PR
  • Code changes appear correct
  • No changes were visible in the UI

Approved!

@yielderdev yielderdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tomomi-K1 ! In review:

  • The pull request done with the correct branch
  • There is a linked issue: #7764

Issue instruction: Do not use a tab to indent github-handle. YAML doesn't allow tabs; it requires spaces.

  • Syntax correct according to YAML standards and specifications of the linked issue

Issue instruction: Using docker, confirm that the appearance of the project webpage is unchanged at all screen sizes.

  • No visual changes from PR changes
  • Other websites pages tested and working fine

Nice Job! The changes are applicable, don't break anything on desktop or mobile from my testing, and are clean + consistent.

Approved.

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Aug 19, 2026
@castillios
castillios merged commit cc89922 into hackforla:gh-pages Aug 19, 2026
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers HLC: C Homepage Launch Countdown Could Have P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Joshua Bubar in new-schools-today.md

4 participants