amico-slack: dedup Authored by Amico footer and default send to Aaron - #331
Draft
aarontrowbridge wants to merge 1 commit into
Draft
amico-slack: dedup Authored by Amico footer and default send to Aaron#331aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
4 tasks
Fix double _Authored by Amico_ (CLI now strips existing footer loop-idempotent) and default send to Aaron (--as-bot to opt out). Update skill to document idempotent footer and chat:write.customize requirement. CLI fix at ~/.local/bin/amico-slack already live; this PR tracks the versioned doc. Fixes #330
aarontrowbridge
force-pushed
the
fix/amico-slack-footer-sender-330
branch
from
August 20, 2026 08:52
1a24b76 to
32bb7c4
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #330
~/.local/bin/amico-slack: strip existing_Authored by Amico_footer loop-idempotent before appending (fixes double footer when agent writes it into the file), defaultsendto Aaron (--as-botto opt out,--as-userstays for compat), fix_positionalso--thread/--filevalues don't leak into channel/limit parsing. CLI already patched live at~/.local/bin/amico-slack.packages/extension/skills/amico-slack/SKILL.md: document default-to-Aaron, idempotent footer (don't manually add), andchat:write.customize+ reinstall requirement; update CLI table to--as-botopt-out.Verified:
_strip_existing_footer/_positionalunit snippets,amico-slack --help, manual dedup checks.