feat(onboarding): collection Stages 5-7 + handoff (Stage 8) - #445
Merged
Conversation
- Handoff routing: resolveHandoffAction (intent-based), resolvePreFills (seed confirmation), readIntentFromState - Overture SCORE.md complete: all 8 stages defined end-to-end (orientation → intent → context_seed → demo → environment → devices → goals → handoff) - Stage 5-6: pre-fill from seeds with confirmation prompt - Stage 7: free-text goals - Stage 8: onboarding_completed marker + intent-based routing to pulse-designer / normal-session / tour - Golden parity regenerated - Existing overture_rewrite tests updated for complete stage set - 19 new handoff routing tests (table-driven intent combinations)
jeonghun-jj-lee
marked this pull request as ready for review
August 19, 2026 19:45
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe Overture onboarding score now collects environment, device, and goal data after the demo. It records completion at handoff and routes to pulse design, a normal session, or an exploration tour based on recorded intent. ChangesOverture onboarding
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant OvertureScore
participant ProfileState
participant HandoffRouting
participant PulseDesigner
participant NormalSession
OvertureScore->>ProfileState: Read recorded intent
OvertureScore->>HandoffRouting: Resolve intent and seed values
HandoffRouting-->>OvertureScore: Return handoff action
OvertureScore->>PulseDesigner: Start research flow
OvertureScore->>NormalSession: Start coding or exploration flow
Possibly related issues
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #438 — the final slice completing the onboarding flow. Adds collection stages (environment, devices, goals) with seed pre-fill, and the intent-based handoff routing.
What's included
src/handoff_routing.ts:resolveHandoffAction(intents): table-driven routing by intent selections (research → pulse-designer, general → normal-session, exploring → tour, combos)resolvePreFills(state): seed-based confirmation prompts for Stages 5-6readIntentFromState(profile): parse intent array from events streamscores/overture/SCORE.md— now complete with all 8 stages:Acceptance Criteria coverage
Tests
19 new tests in
test/handoff_routing.test.ts+ updated overture_rewrite tests.Closes #438
Summary by CodeRabbit
New Features
Bug Fixes