Skip to content

Fix onboarding webview typecheck - #448

Merged
jack-champagne merged 1 commit into
mainfrom
fix/onboarding-webview-typecheck
Aug 20, 2026
Merged

Fix onboarding webview typecheck#448
jack-champagne merged 1 commit into
mainfrom
fix/onboarding-webview-typecheck

Conversation

@jack-champagne

@jack-champagne jack-champagne commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

  • mark the browser-side onboarding entry point as a module
  • restore the declared global Window augmentation and inferred callback types

Validation

  • pnpm --filter amicode typecheck

This fixes the pre-existing fast CI failure seen on main and is intentionally separate from PR #446.

Summary by CodeRabbit

  • Chores
    • Updated internal module handling without changing user-visible behavior.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ae10f7c3-2ad6-42f7-ae3a-ce7335fc6695

📥 Commits

Reviewing files that changed from the base of the PR and between 586747c and 7d2b7c0.

📒 Files selected for processing (1)
  • packages/extension/src/onboarding_webview.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The onboarding webview entry point now includes an empty export. This establishes external module scope without changing runtime behavior or exported declarations.

Changes

Onboarding webview module

Layer / File(s) Summary
Declare external module scope
packages/extension/src/onboarding_webview.ts
Adds an empty export to establish module scope. No runtime logic changes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7d2b7

This is a small, localized TypeScript typecheck fix with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers: jeonghun-jj-lee

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing the onboarding webview typecheck.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/onboarding-webview-typecheck

Comment @coderabbitai help to get the list of available commands.

@jack-champagne
jack-champagne merged commit 472a285 into main Aug 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant