Keep commas unescaped in query parameters - #542
Merged
Conversation
`UrlBuilder.appendQuery` escaped string values with
`encodeURIComponent`, which turns a comma into `%2C`. The Data APIs
use the comma as a list separator, so a call such as
`InteractiveApi.getFeatures({ id: "id1,id2" })` asked for a single
feature whose id contains a comma instead of for two features. Array
values were already joined with a literal comma, so the two branches
of the same method disagreed.
The comma is a sub-delimiter and is valid unescaped in a query
component, so restore it after encoding.
Relates-To: HERESUP-89500
Signed-off-by: Oleksii Zubko <ext-oleksii.zubko@here.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #542 +/- ##
================================================
+ Coverage 90.9926% 90.9958% +0.0032%
================================================
Files 86 86
Lines 2831 2832 +1
Branches 389 390 +1
================================================
+ Hits 2576 2577 +1
Misses 108 108
Partials 147 147 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UrlBuilder.appendQueryescaped string values withencodeURIComponent, which turns a comma into%2C. The Data APIs use the comma as a list separator, so a call such asInteractiveApi.getFeatures({ id: "id1,id2" })asked for a single feature whose id contains a comma instead of for two features. Array values were already joined with a literal comma, so the two branches of the same method disagreed.The comma is a sub-delimiter and is valid unescaped in a query component, so restore it after encoding.
Relates-To: HERESUP-89500