docs: align infinite-repeat guidance with bounded repeat: -1 lint - #3795
Open
jbernard077 wants to merge 1 commit into
Open
docs: align infinite-repeat guidance with bounded repeat: -1 lint#3795jbernard077 wants to merge 1 commit into
jbernard077 wants to merge 1 commit into
Conversation
Since v0.7.71 (heygen-com#2763), gsap_infinite_repeat demotes to a warning when the root declares a finite data-duration: deterministic seeking and export clip to that explicit window. Without one it remains a hard error (unbounded timeline duration breaks render planning). Update every doc site that still teaches the old absolute ban — the core determinism contract, the animation adapter notes, and the design-guide tables/checklists — to state the bounded allowance and keep the finite-count formula for loops that must end before the composition does. skills/hyperframes-animation/rules/ambient-glow-bloom.md is intentionally untouched: its shimmer must stop before the composition ends, which is exactly the case where a computed finite count is still required.
jbernard077
force-pushed
the
docs/bounded-infinite-repeat
branch
from
September 9, 2026 02:06
4822e3a to
79228e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2794, which was closed as stale and cannot be reopened. Same branch, single signed commit, rebased onto current
mainon 2026-09-08. Both items from the earlier review are addressed: manifest regenerated, andskills/embedded-captions/modes/standard/_anatomy.mdupdated to the bounded form.What
Updates the skill docs and design guides to match the lint behavior shipped in v0.7.71 (#2763):
gsap_infinite_repeatnow demotes to a warning when the composition root declares a finitedata-duration— deterministic seeking and export clip to that explicit window. Without a finite composition duration it remains a hard error (the timeline can report an unbounded length and render planning fails).Eleven files still taught the old absolute ban ("never
repeat: -1"). This PR updates each one-liner to state the bounded allowance, and keeps theMath.max(0, Math.floor(duration / cycle) - 1)formula for the case that still needs it: loops that must end before the composition does.Files
skills/hyperframes-core/SKILL.md+references/determinism-rules.md— the canonical contract; determinism-rules now spells out both severitiesskills/hyperframes-animation/SKILL.md,adapters/gsap.md,adapters/gsap-timeline-and-labels.md,rules-index.md— restatements of the core ruleskills/figma/SKILL.md,skills/talking-head-recut/SKILL.md,skills/remotion-to-hyperframes/references/limitations.md— workflow-level restatementsdocs/guides/claude-design-hyperframes.md,docs/guides/claude-design-send-to-hyperframes.md— determinism table rows + render checklistsIntentionally untouched:
skills/hyperframes-animation/rules/ambient-glow-bloom.md— its shimmer must stop before the composition ends (killed at resolve), which is exactly the case where a computed finite count is still the right guidance.Verified against
Behavior confirmed on a minimal composition (two
repeat: -1tweens, rootdata-duration="4"): 0.7.67 fails with thegsap_infinite_repeaterror; 0.7.71 passescheckwith the warning and renders 120 frames clipped to the 4s window.Docs-only change — no code touched.
🤖 Generated with Claude Code