fix(producer): pass stub formatter path as an argument - #3827
Closed
jrusso1020 wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Superseded by merged PR #3834 (db51d54): the producer now calls formatGeneratedSource, which invokes bun x oxfmt through execFileSync with an argument array. The vulnerable shell interpolation is gone. Code-scanning alert #447 is independently verified fixed on main at 2026-09-10T03:20:05Z. Closing this redundant PR without merging; preserving the branch/worktree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A checkout path containing shell metacharacters could execute commands when the producer formats its generated early stub (CodeQL #447). Invoke
bun x oxfmtwith an argument array so the full output path stays data.bunxis the documented alias forbun x: https://bun.sh/docs/pm/bunx.Generated stub contents, formatter selection, and the existing nonfatal formatter-failure behavior are preserved.
Validation:
Native CI and independent review are required before merge.