fix(cli): hide Windows console for remaining child-process spawns - #3960
Open
lorenzozanee wants to merge 1 commit into
Open
lorenzozanee wants to merge 1 commit into
lorenzozanee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hide Windows console windows for three remaining child-process spawns in
@hyperframes/climissed by the earlierwindowsHidecoverage (#3379 in engine, #3529 in cli):telemetry/transport.tsflushSync()— spawns a detachednodeon every CLI exit to deliver queued eventsutils/clipboard.ts—whereprovider probe and the provider copy itself (clip.exeon Windows)server/portUtils.tswindowsListenerPid()—netstatlookup used by preview--list/--stop/conflict logging on WindowsEach site now passes
windowsHide: true, a no-op on macOS/Linux. Three regression tests mirror the existing*.windowsHide.test.tsstyle.Why
These binaries are console-subsystem on Windows, so spawning them without
windowsHidepops a visible console window — including from contexts that own no console (detached preview server, exit-time flush). This closes out the remaining scope of #3500: everyspawn/execFile/spawnSyncsite reachable on Windows incli,studio-server,lintandenginenow carries the flag.How
One-line option additions only, following the exact pattern already merged in
orphanCleanup.ts,manager.ts,preflight.ts,mediaMetadata.ts,waveform.ts,proxyTranscoder.ts,mediaValidation.tsandhevcPreviewLint.ts. No refactor, no new abstraction, no behavior change on non-Windows platforms.Test plan
transport,clipboard,portUtilswindowsHide tests) fail on base with the flag missing and pass after the fix; existingportUtils.test.tsand all runnable*.windowsHide.test.tssuites pass;oxlint/oxfmtclean;tsc --noEmitshows only pre-existing missing-generated-file errorsCloses #3500
Supersedes #3956(原PR分支已删,按原提交重建)