fix(producer): bound nested media by a host's data-duration when it has no data-end - #3965
Open
valeriangalliat wants to merge 1 commit into
Open
valeriangalliat wants to merge 1 commit into
valeriangalliat wants to merge 1 commit into
Conversation
…as no data-end The runtime hides a slot's descendants at data-start + data-duration, and the compiler only stamps data-end on media tags, so a composition host authored with data-duration was unbounded for the media planner: audio and video nested in a shortened scene kept playing over the next scene. The template-wrapped compile test asserted that unbounded end (a 4s clip in a 2s slot ending at 6); it now expects the slot end.
valeriangalliat
added a commit
to ArcadeHQ/hyperframes-next
that referenced
this pull request
Sep 15, 2026
valeriangalliat
added a commit
to ArcadeHQ/hyperframes-next
that referenced
this pull request
Sep 15, 2026
valeriangalliat
added a commit
to ArcadeHQ/hyperframes-next
that referenced
this pull request
Sep 15, 2026
valeriangalliat
added a commit
to ArcadeHQ/hyperframes-next
that referenced
this pull request
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the render media planner, a composition host authored with
data-durationbut nodata-endnow closes atdata-start + data-duration, so the audio and video nested inside it stop at the slot end.Fixes #3964.
Why
resolveHostWindowbounded a host bydata-endonly, andcompileTimingAttrsnever stampsdata-endon composition hosts, so a slot authored withdata-durationwas unbounded for the planner: a scene's audio kept playing over the next scene while the runtime (since #1662) already hid the slot's timed descendants at start + duration. Pixels and audio disagreed about where the slot ends; preview and render disagreed too, since the runtime media sync honours the authored host window.How
renderMediaCollector.tsgainsresolveHostEnd(host, hostStart):data-endwins, elsehostStart + data-duration, else unbounded as before.hostStartis the already-resolved start, so id-ref hosts (data-start="intro") are bounded correctly too. Open-ended media inside a bounded host now closes with the host instead of stayingend: 0.One existing compile test (
offsets template-wrapped media to the host start during compile) asserted the unbounded end — a 4s clip in a 2s slot ending at 6 — and now expects the slot end (4).Test plan
closes a host authored with data-duration but no data-endcase (numeric and id-ref hosts, a clip starting after the slot is dropped); legacy-global and template-wrapped tests updated for the bounded end.