fix(di): bind Session\SessionLifecycle to its factory explicitly - #231
Open
jcdelepine wants to merge 1 commit into
Open
jcdelepine wants to merge 1 commit into
jcdelepine wants to merge 1 commit into
Conversation
SessionLifecycleFactory (introduced by e1548bd) absorbs a legacy type mismatch: SessionLifecycle's constructor expects a SessionSecret, but the legacy 'Horde_Secret_Cbc' DI binding resolves to Horde_Core_Secret_Cbc, which does not implement that interface. The factory checks instanceof and falls back to a no-secret, rekey-disabled lifecycle instead of a fatal type error. Bare constructor reflection (the injector's fallback without an explicit binding) bypasses this factory entirely, reopening the exact failure e1548bd fixed — same failure class as horde#190 (Session\HordeSessionFactory). Bind Session\SessionLifecycle::class => Session\SessionLifecycleFactory::class in DefaultInjectorBindings.php so the container always goes through the factory's compatibility handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SessionLifecycleFactory (introduced by e1548bd) absorbs a legacy type mismatch: SessionLifecycle's constructor expects a SessionSecret, but the legacy 'Horde_Secret_Cbc' DI binding resolves to Horde_Core_Secret_Cbc, which does not implement that interface. The factory checks instanceof and falls back to a no-secret, rekey-disabled lifecycle instead of a fatal type error. Bare constructor reflection (the injector's fallback without an explicit binding) bypasses this factory entirely, reopening the exact failure e1548bd fixed — same failure class as #190 (Session\HordeSessionFactory).
Bind Session\SessionLifecycle::class => Session\SessionLifecycleFactory::class in DefaultInjectorBindings.php so the container always goes through the factory's compatibility handling.
Spotted while working on the OIDC integration — base's login/logout refactor already relies on SessionLifecycle via LoginServiceFactory, which is what surfaced the missing binding. Unrelated to OIDC itself and has no dependency on those PRs, same failure class as #190.