feat(review): shorten and simplify review comments - #39
Conversation
There was a problem hiding this comment.
Important
The one-finding rule conflicts with required blocking summaries and should be scoped before merge.
Reviewed changes Reviewed the new organization-wide review-comment style contract and its interaction with the existing output rules.
-
Controlled language — Adds sentence length, voice, terminology, uncertainty, tense, and pronoun constraints for inline and summary comments.
-
Comment structure — Requires claim-first feedback, fix-before-derivation ordering, and one finding per comment.
-
Severity-scaled evidence — Requires every finding to state its consequence while varying supporting proof by severity.
GPT Sol | 𝕏
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the prompt-contract fixes added since the prior Pullfrog review.
- Inline finding scope — Limited the one-finding rule to inline comments, preserving the required aggregate blocking summary.
- Context disclosures — Exempted mandatory partial-context disclosures from the subject-deletion rule.
- Proof wording — Simplified the blocking-proof instruction without changing its requirement.
GPT Sol | 𝕏

Adds a
## Comment Stylesection telling the reviewer to write its comments in simplified technical English, one finding per comment, with the proof scaled to severity while the consequence is always stated.Measured by rewriting 14 real posted comments from this repo (#38) and runtimedb (#1242, #1236) under each candidate ruleset:
<details>foldsTwo earlier approaches were dropped with cause. Sentence caps failed three independent ways (a 4-sentence super nit cannot hold claim + evidence + consequence + fix; the count is gameable, since a fix costs 0 sentences as code and 1 as prose; and the word cap and sentence cap compete).
<details>folds cut only 2% of real volume — they relocate text, and folded text returns whole through<prior_review_comments>on later cycles — while hiding scope-limiting facts, which made comments read more severe than the originals. A first draft of proof-scaling coupled proof to convention-existence and dropped the consequence on the two highest-impact findings in the set; that clause is gone and the consequence is now unconditional.Known limits, worth watching rather than fixing blind:
The prompt document is measured at runtime and subtracted from the diff's context allowance, so this section is sized deliberately: 1,193 bytes, leaving 107 before
tests/context-step-test.shstarts omitting diffs that currently fit.Deploys org-wide from
mainon merge. Rollback is a one-file revert.