Rename user-facing term "managed database" to "instant database" - #54
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
||
| def _resolve_managed_connection(self, database_id: str) -> dict[str, Any]: | ||
| """Resolve a managed database by id, returning its detail dict.""" | ||
| """Resolve an instant database by id, returning its detail dict.""" |
There was a problem hiding this comment.
nit: (not blocking) The private helpers got renamed, but the two public API docstrings and their user-facing error messages still say "managed":
backend.py:572—"""Create a managed Hotdata connection (Ibis catalog) with optional declared tables."""backend.py:582—"Hotdata create_database creates a managed connection (catalog); "backend.py:601—"""Delete a managed Hotdata connection (Ibis catalog)."""backend.py:608—"Hotdata drop_database deletes a managed connection (catalog); "
These are the most user-visible strings of the set (they show up in help(con.create_database) and in raised UnsupportedOperationError text), so leaving them on the old term partly defeats the rename. If "managed connection" is deliberately a different concept from "managed database" here, ignore this — but the surrounding code uses the two interchangeably (_resolve_managed_connection is the "instant database" lookup).
| just a single trivial column. | ||
|
|
||
| Ad hoc/federated querying (raw ``Connection`` tables, no managed database) is | ||
| Ad hoc/federated querying (raw ``Connection`` tables, no instant database) is |
There was a problem hiding this comment.
super nit: (not blocking) Lines 2 and 5 of this same module docstring were missed:
- L2:
"""Ibis table expressions against a managed Hotdata database, executed to pandas. - L5:
aggregate against two small managed tables (customer, orders). Distinct from
L2 is the same term being renamed, so the file now reads "managed Hotdata database" in the summary line and "instant database" ten lines later. (L5's "managed tables" is arguably a separate term — your call.)
| ``` | ||
|
|
||
| ## Managed databases | ||
| ## Instant databases |
There was a problem hiding this comment.
super nit: (not blocking) README.md:263 in the "What's supported" table still reads `create_database` / `drop_database` (managed). That parenthetical is prose, not an identifier, so it should probably become (instant) to match the new section heading.
1 participant
Renames the user-facing product term managed database(s) to instant database(s) across the README, example docstrings/comments/print output, code docstrings and comments, and one user-facing error message (test assertion updated in lockstep).
Intentionally unchanged:
create_managed_database,MANAGED_DB_ID,_resolve_managed_connection,/v1/databases) — wire format and internal names keepmanaged.No behavior changes; test suite passes.