feat(create): show Included feed starters on empty Create - #1112
Merged
Conversation
Always select starter feeds in session, and surface them under an empty Create URL as lean Included feeds (Notice only when creation is disabled).
Swap FE and Ruby STARTER_FEED_IDS to Faraday-stable IGO/gov configs and document empty-URL Included feeds in Journey Grammar.
Rename showStarters to shouldShowStarters and assert preferred starter ids resolve in the merged catalog.
Use the docs SSOT product name for starters, find chrome, and utility links; drop Try included feeds drift and lean hint noise.
Reuse utility-link for the lean under-list escape, put muted color on notice meta anchors, and share Browse Feed Directory (N) with the utility strip using catalogEntries.length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
field-help+CatalogHitList(role="list", no Notice) when creation is enabled; Notice + intro + learn-more when creation is disabled.shouldShowStartersinAppPanels.tsx).useSessionalways runsselectStarterFeeds(no longer gated on creation disabled).STARTER_FEED_IDSswapped tofao.org/newsroom,ftc.gov/press-releases,icrc.org/newsin FE (parseCatalog.ts) and Ruby (Catalog::Merge) lockstep.Why
Create stays URL-primary; Included feeds are subordinate demos so an empty create path is not a dead end. Faraday-stable IGO/gov configs replace the previous Azure/phys.org starters for more reliable demos.
Risk
Validation
review.gilfindings): readiness Yes; Important catalog-resolve gap fixed in follow-up commitmake ready— exit 0make ci-ready— exit 0 (OpenAPI verify + Playwright e2e smoke)Test plan