feat(catalog): last_result and meta.starters on configs v2 - #1113
Merged
Conversation
Record process-local scrape outcomes on directory-defaults static feeds and join them into typed catalog entries so clients can demote failing rows and consume server-owned meta.starters instead of lockstep starter ID lists.
Parse catalog_version 2 last_result and meta.starters, delete the lockstep STARTER_FEED_IDS list, and demote empty/error rows in catalog find ranking.
Seed warm last_result rows in the configs OpenAPI example so code/at infer as string|null, and cover empty/error LastResults recording.
Spectral validates OAS 3.0 schemas; emit nullable: true instead of 3.1+ type unions, and register the Catalog operation tag globally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
last_resulton entries andmeta.starters(replaces frontend lockstepSTARTER_FEED_IDS).Feeds::LastResults/LastResult; record onService#build_resultonly for directory-defaults scrapes.Catalog::Entryvia merge;Catalog::Startersowns the starter list server-side.parseCatalog, ranking demotion for empty/error rows) and consumesmeta.starters.last_result.code/attostring|null(assure fix7f0aa8f8).Why
Clients need scrape outcome signals and a single source of truth for Create-page starters without hardcoding feed IDs in the frontend. Directory defaults scrapes are the only path that should populate process-local last_result.
Risk
last_result/meta.starters). html2rss.github.io is out of scope for this PR.Review map
app/web/feeds/last_results.rb+app/web/feeds/service.rb— process-local store and record-on-build gateapp/web/catalog/starters.rb+app/web/catalog/merge.rb/entry.rb— starters + last_result join into catalog rowsapp/web/api/v1/configs.rb+public/openapi.yaml— v2 contract and nullability of code/atfrontend/src/catalog/parseCatalog.ts+findCatalogEntries.ts— consume meta.starters / demote empty|errorspec/html2rss/web/feeds/andspec/html2rss/web/catalog/— recording, merge, startersValidation
make ready— exit 0 (Dev Container)make ci-ready— exit 0 (Dev Container)