docs: fix fork clone command in contributing guide - #1951
Open
chenlichao wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the fork-cloning command in
CONTRIBUTING.mdto use the current repository name,cli.git, and explicitly name the checkout directoryhttpieso the followingcd httpiecommand and later paths remain correct.The guide links to
httpie/cli, but the clone command still assumes a fork namedhttpie. A newly created fork with GitHub's default name is<YOU>/cli, so the documented remote does not exist for that fork.This is intentionally a one-line, documentation-only change (1 addition, 1 deletion); no runtime behavior changes.
Verification
httpie/cliand confirmed its parent and name through the GitHub API.git ls-remote: the oldchenlichao/httpie.gittarget failed with “Repository not found”; the correctedchenlichao/cli.gittarget resolved to the same HEAD as upstreammaster. Used Git's per-command SSH-to-HTTPS URL rewrite for these checks because authentication is configured over HTTPS.bash -n.cd httpie.git diff --checkpassed; manually reviewed the one-line diff.The application test suite was not run because only a Git command in the contributor guide changes. No full clone or SSH authentication test was performed.