Fix many (not all) clippy::pedantic warnings. - #8
Open
dbongartz wants to merge 1 commit into
Open
Conversation
This adds some unwraps on integer casts which "should" never happen. It also adds one which will always happen at `signal_scaling_safety_checker.rs:275` which I am not sure how to resolve. This is better than before where all of this silently wrapped. The rest should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK, this is a a bit bigger. I just ran clippy with pedantic and fixed stuff while reviewing the code for usage at work. It's completely optional for me, but it should at least be looked at because of the silent wraparounds which could occur before the change.
This adds some unwraps on integer casts which "should" never happen.
It also adds one which will always happen
at
signal_scaling_safety_checker.rs:275which I am not sure how to resolve.
The rest should be fine.