Bump dependencies - #9
Open
dbongartz wants to merge 1 commit into
Open
Conversation
kilpkonn
reviewed
Aug 19, 2026
| offset: value.offset, | ||
| min: value.min, | ||
| max: value.max, | ||
| min: numeric_value_to_float(value.min), |
There was a problem hiding this comment.
I wonder if we can change the types of min/max to NumericValue instead and perhaps simplify code elsewhere? Pretty sure there is some detection for int / float somewhere.
Contributor
Author
There was a problem hiding this comment.
I started doing that, but can_dbc::NumericValue does not implement Hash. It probably should though... So the next steps to fix that looked like a rabbit hole... which I didn't want to go for a version bump :)
Feel free to close this if you prefer a proper solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely optional, just noticed some where behind current.