IBX-11833: Added a unique field-type option to prevent duplicate Meta fields - #2012
Open
mateuszdebinski wants to merge 1 commit into
Open
IBX-11833: Added a unique field-type option to prevent duplicate Meta fields#2012mateuszdebinski wants to merge 1 commit into
mateuszdebinski wants to merge 1 commit into
Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
August 17, 2026 12:04
|
mateuszdebinski
changed the title
ViniTou
reviewed
Aug 26, 2026
ViniTou
left a comment
ViniTou
left a comment
Contributor
There was a problem hiding this comment.
Is this really the best place to add buisness logic like this into presentation (admin-ui) layer? what if that content type is going to be created outside it?
barw4
reviewed
Aug 26, 2026
|
|
||
| foreach ($metaFieldTypes as $metaFieldTypeIdentifier => $metaFieldTypeSettings) { | ||
| $fieldGroup = $this->getDefaultMetaDataFieldTypeGroup() ?? $this->fieldsGroupsList->getDefaultGroup(); | ||
| $fieldTypeGroup = $metaFieldTypeSettings['unique'] ? null : $fieldGroup; |
Contributor
There was a problem hiding this comment.
can we make stricter comparison here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
A field type could get duplicated into a Content Type when its resolved field group differed from where an existing instance already lived (e.g., SEO metadata re-added on edit). The unique flag lets a field type opt out of the group-scoped check so it's only ever added once, regardless of group.
For QA:
Documentation: