5.0: Use RelationListIterator - #2548
Merged
Merged
Conversation
Fix "Argument #1 ($contentId) must be of type int, string given"
loadRelations is deprecated in 4.5, and removed in 5.0 Fix "Call to an undefined method Ibexa\Contracts\Core\Repository\ContentService::loadRelations()." on PHPStan + 5.0
loadRelations is deprecated in 4.5, and removed in 5.0 Fix "Call to an undefined method Ibexa\Contracts\Core\Repository\ContentService::loadRelations()." on PHPStan + 5.0
7 tasks
# Conflicts: # code_samples/api/public_php_api/src/Command/ViewContentMetaDataCommand.php # code_samples/front/embed_content/src/Controller/RelationController.php # docs/content_management/content_api/browsing_content.md
# Conflicts: # docs/content_management/content_api/browsing_content.md
adriendupuis
commented
Jun 6, 2025
Preview of modified filesPreview of modified Markdown: |
# Conflicts: # docs/api/php_api/php_api_reference/classes/Ibexa-Contracts-Core-Repository-Iterator-BatchIteratorAdapter-RelationListIteratorAdapter.html
adriendupuis
marked this pull request as ready for review
July 22, 2025 10:13
mnocon
requested changes
Jul 22, 2025
mnocon
left a comment
Contributor
There was a problem hiding this comment.
No comments about the code, looks solid 💪
Only one suggestion about the wording, as it's not clear to me right now.
mnocon
reviewed
Jul 31, 2025
mnocon
left a comment
Contributor
There was a problem hiding this comment.
I'd mention https://doc.ibexa.co/en/latest/search/search_api/#processing-large-result-sets for people not familiar with it (I've found this page only recently, when adjusting the code samples for v5)
# Conflicts: # docs/content_management/content_api/browsing_content.md # docs/templating/embed_and_list_content/embed_content.md
adriendupuis
force-pushed
the
5.0-relationlistiterator
branch
from
August 25, 2026 10:22
bf389ca to
c3599fe
Compare
Summary
|
adriendupuis
force-pushed
the
5.0-relationlistiterator
branch
from
August 25, 2026 10:55
8cdb1ab to
304c554
Compare
mnocon
reviewed
Aug 25, 2026
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
code_samples/ change report
|
code_samples/ change report
|
adriendupuis
added a commit
that referenced
this pull request
Aug 26, 2026
To get all relations, use `RelationListIteratorAdapter` + `BatchIterator` instead of `ContentService::countRelations()` + `ContentService::loadRelationList()` --------- Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
adriendupuis
added a commit
that referenced
this pull request
Aug 26, 2026
To get all relations, use `RelationListIteratorAdapter` + `BatchIterator` instead of `ContentService::countRelations()` + `ContentService::loadRelationList()` --------- Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get all relations, use
RelationListIteratorAdapter+BatchIteratorinstead ofContentService::countRelations()+ContentService::loadRelationList()Follows #2544 and in particular this comment.
Previews:
Checklist