feat(sequences): sequence CRUD and sequence email management - #15
Merged
Conversation
Closes the gap the spec-change issues flagged for sequences. Sequence CRUD (issue #4): kit sequences get <id> kit sequences create --name <name> [...] kit sequences update <id> [...] kit sequences delete <id> Sequence emails (issue #6), nested under sequences: kit sequences emails list <sequenceId> kit sequences emails get <sequenceId> <id> kit sequences emails create <sequenceId> --subject --delay-value --delay-unit kit sequences emails update <sequenceId> <id> [...] kit sequences emails delete <sequenceId> <id> Both list and get accept --include stats, which the spec added alongside the description changes in issue #7. Sequence email list also accepts --include-content. Update commands send only the fields the user names, so an update never wipes a field by accident. Send days, send hour, delay unit, and ID lists are validated before the request goes out. Adds validateIntInRange and validateEnum to the client. validateNumericId rejects zero, which send hour and position both allow.
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 8. Base: #14.
What this adds
Sequence CRUD:
Sequence emails, nested under
sequences:listandgetaccept--include stats.emails listalso accepts--include-content.Design notes
The update commands send only the fields that the user names. An update therefore never wipes a field by accident. The tests cover this.
The CLI validates send days, send hour, delay unit, and ID lists before it sends the request. A bad value reads as a CLI error instead of a 422.
validateNumericIdrejects zero. Send hour and email position both allow zero. This branch addsvalidateIntInRangeandvalidateEnumto the client for those cases.Review notes
Tests: 147 before, 198 after. The 51 new tests assert the exact request for every new command.
Closes #6
Part of #4
Part of #7
The stack
Merge from the top down. Each part builds on the one above it.
Base branch:
mainfor part 1, the previous part's branch for the rest.GitHub retargets each base to
mainas the part below it merges.