Conversation
|
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (3)badge-canvas.png — 1573 pixels differtooltip-dark.png — 881 pixels differtooltip-light.png — 956 pixels differBaselines come from the |
9d02c38 to
196c515
Compare
The rules live in two places so they hold whichever way someone arrives: CLAUDE.md for an agent session, docs/contributing for a human contributor. commitlint's headerPattern could not match a scoped subject like `fix(ui-button): ...`, so the conventional parser never ran and subject-max-length applied to nothing. Dropping the pattern lets the parser work, and the cap drops from 150 to 100 - 78 of the last 2000 subjects were over 100, and those are the ones listing every package touched instead of naming the change. Co-Authored-By: Claude <noreply@anthropic.com>
No longer on the team, so /pr should stop offering them as a reviewer. Co-Authored-By: Claude <noreply@anthropic.com>
196c515 to
f03ab99
Compare
balzss
changed the title
There was a problem hiding this comment.
What about using the rules here for both commit and PR messages? https://github.com/ayghri/i-have-adhd/blob/main/skills/i-have-adhd/SKILL.md#rules (do not copy it literally, some rules are irrelevant here)
| the way an external consumer would. | ||
| ``` | ||
|
|
||
| Writing about _before_ and _after_ is encouraged — "Previously the placeholder only showed on hover" is exactly right in a commit message, which is permanently anchored to its own diff. (Code comments are different: see CLAUDE.md.) |
There was a problem hiding this comment.
no need for this part:
"(Code comments are different: see CLAUDE.md.)"
2 participants
Summary
CLAUDE.md, with a human-facing version in thecontributor docs: explain why not what, one line, never reference the change itself.
commitlint.config.js'sparserOpts.headerPattern, which couldn't match a scopedsubject like
fix(ui-button): ..., so the conventional parser never ran andsubject-max-lengthapplied to nothing. Cap the subject at 100./commit's guidance on commit bodies, and drop the robot attribution linefrom commit messages.
/prreviewer roster — no longer on the team.Test Plan
subject-max-length: 100checked against history: 78 of the last 2000 subjects exceedit, and they're the ones enumerating every package touched instead of naming the change.
the preset's
body-max-line-length) — and that comma scopes likefix(ui-drawer-layout,ui-a11y-utils):still parse.Fixes INSTUI-5174
🤖 Generated with Claude Code