Skip to content

fix(runtime): append new VamanaIndex virtuals instead of inserting them #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahuber21 merged 2 commits into from
Sep 9, 2026
Merged

fix(runtime): append new VamanaIndex virtuals instead of inserting them #385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08a335c
fix(runtime): append new VamanaIndex virtuals instead of inserting them
ahuber21 Sep 9, 2026
8ba81cb
Merge branch 'main' into fix/vamana-index-vtable-append
ahuber21 Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions bindings/cpp/include/svs/runtime/vamana_index.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,6 @@ struct SVS_RUNTIME_API VamanaIndex {
// Reconstruct `n` vectors by ID into `output` buffer (n * dim floats).
virtual Status reconstruct_at(size_t n, const size_t* ids, float* output) noexcept = 0;

// Return the index memory usage in bytes.
virtual size_t get_memory_usage() const noexcept = 0;

// Return the bytes allocated by each index component.
virtual Status get_memory_breakdown(MemoryBreakdown* out) const noexcept = 0;

// Utility function to check storage kind support
static Status check_storage_kind(StorageKind storage_kind) noexcept;

Expand All @@ -120,6 +114,13 @@ struct SVS_RUNTIME_API VamanaIndex {
static Status destroy(VamanaIndex* index) noexcept;

virtual Status save(std::ostream& out) const noexcept = 0;

// Return the index memory usage in bytes.
virtual size_t get_memory_usage() const noexcept = 0;

// Return the bytes allocated by each index component.
virtual Status get_memory_breakdown(MemoryBreakdown* out) const noexcept = 0;

static Status load(
VamanaIndex** index, std::istream& in, MetricType metric, StorageKind storage_kind
) noexcept;
Expand Down
Loading