WEBDEV-8972: Run CI on every PR, not just ones based on main - #90
Merged
Conversation
The pull_request branch filter matches the PR's base branch, so a PR based on another branch never ran the tests at all. Only the preview deploy did, which has no filter. That's every stacked PR. The tests do eventually run, since GitHub retargets each PR to main as the one below it merges, but that's after review, so a reviewer looking at the middle of a stack sees a green PR that was never tested. Push stays filtered to main. Claude-Session: https://claude.ai/code/session_01U6iNyGicKJywdrWJMTyFin Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 81.12% 81.12%
=======================================
Files 27 27
Lines 927 927
Branches 227 227
=======================================
Hits 752 752
Misses 113 113
Partials 62 62 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jbuckner
enabled auto-merge (squash)
August 27, 2026 20:26
jbuckner
added a commit
that referenced
this pull request
Aug 27, 2026
…udio-element * origin/main: WEBDEV-8972: Run CI on every PR, not just ones based on main (#90)
jbuckner
added a commit
that referenced
this pull request
Aug 27, 2026
…rate-waveform-progress * WEBDEV-8963-migrate-audio-element: WEBDEV-8972: Run CI on every PR, not just ones based on main (#90)
jbuckner
added a commit
that referenced
this pull request
Aug 27, 2026
…-migrate-playback-controls * WEBDEV-8964-migrate-waveform-progress: WEBDEV-8972: Run CI on every PR, not just ones based on main (#90)
jbuckner
added a commit
that referenced
this pull request
Aug 27, 2026
…-migrate-scrubber-bar * WEBDEV-8965-migrate-playback-controls: WEBDEV-8972: Run CI on every PR, not just ones based on main (#90)
jbuckner
added a commit
that referenced
this pull request
Aug 27, 2026
…ate-expandable-search-bar * WEBDEV-8966-migrate-scrubber-bar: WEBDEV-8972: Run CI on every PR, not just ones based on main (#90)
jbuckner
added a commit
that referenced
this pull request
Aug 27, 2026
…8968-migrate-transcript-view * WEBDEV-8967-migrate-expandable-search-bar: WEBDEV-8972: Run CI on every PR, not just ones based on main (#90)
jbuckner
added a commit
that referenced
this pull request
Aug 27, 2026
…igrate-search-handler * WEBDEV-8968-migrate-transcript-view: WEBDEV-8972: Run CI on every PR, not just ones based on main (#90)
jbuckner
added a commit
that referenced
this pull request
Aug 27, 2026
…grate-radio-player * WEBDEV-8974-migrate-search-handler: WEBDEV-8972: Run CI on every PR, not just ones based on main (#90)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WEBDEV-8972.
The
pull_requestbranch filter matches the PR's base branch, so a PR based on another branch never ran the tests at all — onlydeploy-preview, which has no filter.That's every stacked PR. Live example before this change: #85 is based on #84's branch and its only check is
deploy-preview, while #77, based onmain, gets all three.The tests do eventually run, because GitHub retargets each PR to
mainas the one below it merges — but that's after review, so a reviewer looking at the middle of a stack sees a green PR that was never tested.pushstays filtered tomain.This unblocks the WEBDEV-8962 radio player stack (#77–#86), where seven of the eight PRs currently show only a preview deploy.