Fix crash when opening a file with no workspace folder open - #1834
Merged
Conversation
…tems-community#1833) vscode.workspace.workspaceFolders is undefined when no folder/workspace is open, so the non-null assertion threw on every active editor change.
isc-bsaviano
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: Cannot read properties of undefined (reading 'length')in the Extension Host log, causing the extension to fail to activate.vscode.workspace.workspaceFoldersisundefinedin that case, but theonDidChangeActiveTextEditorhandler used a non-null assertion (workspaceFolders!.length > 1) on it..clsfile; the actual root cause was that the extension had failed to activate (this crash), not the language configuration.Test plan
.clsfile with no folder/workspace open in the Extension Development Host and confirmed the error no longer appears in the Extension Host output..clsfile now work.