Skip credential resolution for inactive connections during activation - #1835
Open
isc-klu wants to merge 9 commits into
Open
Skip credential resolution for inactive connections during activation#1835isc-klu wants to merge 9 commits into
isc-klu wants to merge 9 commits into
Conversation
…intersystems-community#1832) resolveConnectionSpec() has no timeout around authentication.getSession(), which can block activate() for minutes per inactive server on slow/VPN hosts. Since checkConnection() already treats inactive connections as a fast no-op, there's no reason to resolve credentials for them first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activate()resolves credentials for every workspace folder connection, even inactive ones, beforecheckConnection()gets a chance to skip them. On slow/VPN hosts this can block activation for minutes.activate()andonDidChangeWorkspaceFolders.Test plan
tsc --noEmitandeslintpass.