Skip to content

Fix crash from unresolved auth on named-server connections - #1836

Merged
isc-klu merged 10 commits into
intersystems-community:masterfrom
isc-klu:clone-undefined
Aug 21, 2026
Merged

Fix crash from unresolved auth on named-server connections#1836
isc-klu merged 10 commits into
intersystems-community:masterfrom
isc-klu:clone-undefined

Conversation

@isc-klu

@isc-klu isc-klu commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes Extension fails to activate, isfs files can no longer be opened #1837AtelierAPI.config/.active call this._config.auth.clone() unconditionally. For a named-server connection, _config.auth was populated from getResolvedConnectionSpec's fallback (the raw, unresolved intersystems.servers entry), whose auth is legitimately undefined until resolveConnectionSpec has run — causing TypeError: Cannot read properties of undefined (reading 'clone') and extension activation failure (breaking isfs file access).
  • getResolvedConnectionSpec now always returns a spec with auth populated, and its dflt parameter is typed to match what's actually passed (a raw IServerSpec, not a fully-resolved spec) so this can't regress silently.
  • Added a config() overload for "intersystems.servers" so callers get a real type instead of any.

Test plan

@isc-klu
isc-klu requested a review from isc-bsaviano as a code owner August 20, 2026 20:57
@isc-klu
isc-klu merged commit 5c72e3c into intersystems-community:master Aug 21, 2026
5 checks passed
@isc-klu
isc-klu deleted the clone-undefined branch August 21, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension fails to activate, isfs files can no longer be opened

2 participants