Fix ServerSpec | undefined type safety and wire up TS project references - #414
Merged
isc-klu merged 22 commits intoAug 25, 2026
Merged
Conversation
- Fix getServerSpec and ProtocolMethods resolveFromUri to return ServerSpec | undefined - Add guards at all getServerSpec call sites across providers - Fix resolveServerSpec in client to avoid non-null assertion - Add TS project references for common from client/server/root - Update clean script to remove tsbuildinfo files - Rename deprecated typescript.* settings to js/ts.*
isc-klu
marked this pull request as ready for review
August 21, 2026 16:28
Collaborator
|
I downloaded the latest dev VSIX for this PR but am still seeing the issue: |
isc-bsaviano
approved these changes
Aug 25, 2026
isc-bsaviano
left a comment
isc-bsaviano
left a comment
Collaborator
There was a problem hiding this comment.
Confirmed this worked with linked main extension PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #413.
getServerSpec()could returnundefinedat runtime, but was typed as always returningServerSpec, silently masking unresolved-server crashes at every call site. This PR fixes the types, adds guards, and wires up TS project references socommon's types are enforced acrossclient/server.