Skip to content

fix(android): preserve request configuration and honor code-only responses - #386

Open
OskarEichler wants to merge 1 commit into
invertase:mainfrom
OskarEichler:codex/android-request-configuration
Open

fix(android): preserve request configuration and honor code-only responses#386
OskarEichler wants to merge 1 commit into
invertase:mainfrom
OskarEichler:codex/android-request-configuration

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 27, 2026

Copy link
Copy Markdown

Fixes: isolate in-flight sign-ins and honor CODE responses

Compatibility / observable changes

CODE now produces a code-only request as documented. Applications that selected CODE but relied on the previously accidental ID token should select ALL explicitly. Defaults, ALL and legacy ID_TOKEN retain their request behavior. No exports or enum values are removed.

Reproduction

Compiled the actual Java module with isolated Android/React bridge/service stubs. Six cases cover three response types and enabled/disabled nonces, replacing configuration before callback. Baseline has two response-type mismatches and six nonce mismatches; the fix has zero of either. This is not a live OAuth flow.

Verification

  • Upstream ESLint and existing TypeScript usage checks pass.
  • Focused inline reproductions compare unchanged 5f7a8d7 with the fix; no test/spec files were changed.
  • React Doctor reports 100/100 on the changed JavaScript scope.
  • Consumer verification now passes on React Native 0.87.1: both Android Debug flavors, both iOS Simulator Debug schemes (unsigned), all four production-mode Metro bundles, immutable Yarn install and app lint. All seven changed installed source files match the verified fork.
  • No real Apple sign-in, account changes, physical-device authentication, macOS/visionOS runtime checks or signed release archives were performed.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants