fix(ios): clear authorization callbacks before invoking them - #387
Open
OskarEichler wants to merge 1 commit into
Open
fix(ios): clear authorization callbacks before invoking them#387OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: one-shot authorization callbacks and safe button callbacks
Compatibility
No public API changes. Authorization settles once, and a button without an attached callback does nothing instead of dereferencing a null block.
Reproduction
Compiled the actual Objective-C callback bodies against Foundation. A reentrant error callback runs twice before the fix and once after; the completion is cleared. Late callbacks, missing button callbacks and an attached button callback are also exercised after the fix.
Verification
5f7a8d7with the fix; no test/spec files were changed.