Skip to content

fix: export runtime values for the declared public enums - #389

Open
OskarEichler wants to merge 1 commit into
invertase:mainfrom
OskarEichler:codex/declared-enum-exports
Open

fix: export runtime values for the declared public enums#389
OskarEichler wants to merge 1 commit into
invertase:mainfrom
OskarEichler:codex/declared-enum-exports

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 27, 2026

Copy link
Copy Markdown

Fix: provide the runtime enum exports already declared by TypeScript

The declarations export nine enums, but lib/index.js exports none of their runtime values. Imports type-check and then evaluate to undefined.

Export AppleButtonType, AppleButtonStyle, AppleError, AppleRequestOperation, AppleRequestScope, AppleRealUserStatus, AppleCredentialState, AndroidResponseType and AndroidScope. Reuse the existing Apple module/button constants; make Android enum values available even when its native module is absent.

Compatibility

Additive exports only. Existing default/module constants and native methods are unchanged. Declared enum names and values are preserved; no new dependency is required.

Reproduction

Evaluate the actual entrypoint and its local modules with a mocked React Native bridge, both with and without native modules. Baseline is missing all nine exports; the fix provides all nine with checked values. Existing TypeScript usage checks also pass.

Verification

  • Upstream ESLint and existing TypeScript usage checks pass.
  • Focused inline reproductions compare unchanged 5f7a8d7 with the fix; no test/spec files were changed.
  • React Doctor reports 100/100 on the changed JavaScript scope.
  • Consumer verification now passes on React Native 0.87.1: both Android Debug flavors, both iOS Simulator Debug schemes (unsigned), all four production-mode Metro bundles, immutable Yarn install and app lint. All seven changed installed source files match the verified fork.
  • No real Apple sign-in, account changes, physical-device authentication, macOS/visionOS runtime checks or signed release archives were performed.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants