fix: export runtime values for the declared public enums - #389
Open
OskarEichler wants to merge 1 commit into
Open
fix: export runtime values for the declared public enums#389OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: provide the runtime enum exports already declared by TypeScript
The declarations export nine enums, but
lib/index.jsexports none of their runtime values. Imports type-check and then evaluate to undefined.Export AppleButtonType, AppleButtonStyle, AppleError, AppleRequestOperation, AppleRequestScope, AppleRealUserStatus, AppleCredentialState, AndroidResponseType and AndroidScope. Reuse the existing Apple module/button constants; make Android enum values available even when its native module is absent.
Compatibility
Additive exports only. Existing default/module constants and native methods are unchanged. Declared enum names and values are preserved; no new dependency is required.
Reproduction
Evaluate the actual entrypoint and its local modules with a mocked React Native bridge, both with and without native modules. Baseline is missing all nine exports; the fix provides all nine with checked values. Existing TypeScript usage checks also pass.
Verification
5f7a8d7with the fix; no test/spec files were changed.