Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: ionic-team/ionic-framework#31001
What is the current behavior?
ModalDragEventDetaildocumentscurrentY,deltaY,velocityY,progress, andsnapBreakpoint. TheisDismissingproperty added in ionic-framework#31002 isundocumented, so there is no reference for when it is
trueor which event includes it.What is the new behavior?
Documents
isDismissingin theModalDragEventDetailinterface:truefor sheet modals, snapping to a breakpoint of 0, and for card modals, passing the threshold required to close.canDismisscallback can still cancel the dismiss after the event is emitted, and thationModalDidDismissconfirms the modal closed.ionDragEnd, notionDragMove.Does this introduce a breaking change?
Other information
Preview