Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
The Japanese site renders 152 broken links, and none of them are visible from this branch. It builds as a single locale at
/docs/, so the defect only appears once this content is consumed as thejalocale of the main site, where the baseUrl is/docs/ja/.That is the cause: links hardcode the
/docsbaseUrl, so Docusaurus prepends the locale's own and the prefix doubles into/docs/ja/docs/theming/basics.What is the new behavior?
0 broken links. 129 link fixes across 41 files.
Rather than re-deriving the rules, I extracted the old to new mapping from main's own diff in #4736, 97 distinct rewrites, and applied it here. Two of them map the same source to different targets depending on context,
/docs/componentsbecoming/componentsin a JSXhrefbut/components.mdxin a markdown link, so they are applied context-aware.That covered 123. The remaining 6 have no counterpart on main:
react.mdxis jp-only, and its "Add Ionic to Existing React App" card pointed at a page renamed upstream long ago. The page here isreact/add-to-existing.mdx.troubleshooting/build.mdxpointed at/docs/faq/runtime#provider-, a page that does not exist.api/app.mdxlinked./リップルエフェクト, which does not exist. The page isapi/ripple-effect.mdx.api/item.mdxhadhref="useBaseUrl('api/modal')"quoted where it needed braces.Does this introduce a breaking change?
Other information
145 broken anchors are left in place on purpose, and 103 of them are a single heading:
### 仮想プロパティneeds{/* #virtual-properties */}. Main's English heading carries no pinned id, so this branch mirrors main until we settle whether headings should carry explicit ids. The other 42 are the same class, translated headings whose slugs cannot match the English anchor.