chore(renovate): keep playwright Dockerfile and package.json in lockstep - #31310
Open
thetaPC wants to merge 1 commit into
Open
chore(renovate): keep playwright Dockerfile and package.json in lockstep#31310thetaPC wants to merge 1 commit into
thetaPC wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The Playwright npm packages and the
mcr.microsoft.com/playwrightDocker image incore/Dockerfileare tracked by two separate Renovate managers. The Docker image is published to the container registry about a day after the npm release, so the two updates become available at different times. Because they are on different datasources, the npm bump opens a PR before the Docker tag is ready, and getting the Dockerfile into the same PR requires a manual rebase once the image lands. This is easy to miss, and merging the npm bump alone leavescore/package.jsonandcore/Dockerfileon mismatched Playwright versions.What is the new behavior?
core/DockerfilePlaywright image tag from the npm@playwright/testrelease instead of the container registry, so both files bump from the same version.playwrightrule, and aminimumReleaseAgeof 3 days lets the matching image publish before the PR opens.playwrightPR that updatescore/package.jsonandcore/Dockerfiletogether, with no manual rebase.Does this introduce a breaking change?
Other information
This is a Renovate config change only, so it will not take effect until the next scheduled Renovate run. If the Docker image for a given release has not been published yet when CI runs, the Dockerfile build can fail on a missing tag; the fix is to wait for the image to appear and re-run the job, with no code change needed. This is documented inline in
renovate.json5.