Skip to content

chore(renovate): keep playwright Dockerfile and package.json in lockstep - #31310

Open
thetaPC wants to merge 1 commit into
mainfrom
playwright-renovate
Open

chore(renovate): keep playwright Dockerfile and package.json in lockstep#31310
thetaPC wants to merge 1 commit into
mainfrom
playwright-renovate

Conversation

@thetaPC

@thetaPC thetaPC commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Issue number: N/A


What is the current behavior?

The Playwright npm packages and the mcr.microsoft.com/playwright Docker image in core/Dockerfile are tracked by two separate Renovate managers. The Docker image is published to the container registry about a day after the npm release, so the two updates become available at different times. Because they are on different datasources, the npm bump opens a PR before the Docker tag is ready, and getting the Dockerfile into the same PR requires a manual rebase once the image lands. This is easy to miss, and merging the npm bump alone leaves core/package.json and core/Dockerfile on mismatched Playwright versions.

What is the new behavior?

  • A custom manager now resolves the core/Dockerfile Playwright image tag from the npm @playwright/test release instead of the container registry, so both files bump from the same version.
  • The built-in Docker manager for that image is disabled so it no longer produces a separate, lagging update.
  • The Dockerfile is added to the grouped playwright rule, and a minimumReleaseAge of 3 days lets the matching image publish before the PR opens.
  • Net result is a single playwright PR that updates core/package.json and core/Dockerfile together, with no manual rebase.

Does this introduce a breaking change?

  • Yes
  • No

Other information

This is a Renovate config change only, so it will not take effect until the next scheduled Renovate run. If the Docker image for a given release has not been published yet when CI runs, the Dockerfile build can fail on a missing tag; the fix is to wait for the image to appear and re-run the job, with no code change needed. This is documented inline in renovate.json5.

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview Jul 30, 2026 11:36pm

Request Review

@thetaPC
thetaPC marked this pull request as ready for review July 31, 2026 00:11
@thetaPC
thetaPC requested a review from a team as a code owner July 31, 2026 00:11
@thetaPC
thetaPC requested a review from brandyscarney July 31, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant