fix unmount race in refresher - #31316
Open
ptmkenny wants to merge 1 commit into
Open
Conversation
|
@ptmkenny is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31315
What is the current behavior?
When an
ion-refresher's host page is unmounted while the native refresher is still being set up, Ionic throws an uncaughtTypeErrorfrom the gesture utility:setupMDNativeRefresher()andsetupiOSNativeRefresher()both do:The dynamic import yields to the event loop. If the refresher is disconnected while it resolves,
disconnectedCallback()(line 547-549) has already runthis.scrollEl = undefined, socreateGesturereceivesel: undefined, and the subsequentdisabledChanged()→gesture.enable(true)callsaddEventListener(undefined, ...), which throws.Because this happens inside an async method that nothing awaits, it surfaces as an unhandled promise rejection — it cannot be caught by a framework error boundary; this crashes my app in playwright sometimes when components are mounted very quickly.
The
!non-null assertions onthis.scrollElare what hide this from TypeScript.What is the new behavior?
If the refresher is disconnected while the gesture module is being imported, setup aborts quietly. No gesture is created, and no error is thrown.
Does this introduce a breaking change?
Other information