Add Prometheus metrics for NX-API client - #446
Open
felix-kaestner wants to merge 1 commit into
Open
Conversation
IvoGoman
reviewed
Jul 17, 2026
IvoGoman
approved these changes
Jul 22, 2026
felix-kaestner
force-pushed
the
nxapi/metrics
branch
from
July 24, 2026 15:35
8ac3026 to
b4aa572
Compare
felix-kaestner
force-pushed
the
nxapi/metrics
branch
from
July 31, 2026 14:42
b4aa572 to
82f3341
Compare
Register two metrics with controller-runtime's metrics registry: - nxapi_rpc_duration_seconds: histogram of HTTP round-trip latency with target and status labels - nxapi_rpc_commands_total: per-command counter with target, command, and status labels Add WithTarget option to associate a device address with metrics for correlating slow-responding devices. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
felix-kaestner
force-pushed
the
nxapi/metrics
branch
from
August 10, 2026 16:30
82f3341 to
034af75
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register two metrics with controller-runtime's metrics registry:
Add WithTarget option to associate a device address with metrics for correlating slow-responding devices.