Skip to content

Harden panning via bound check - #3899

Merged
dingodoppelt merged 1 commit into
jamulussoftware:mainfrom
ann0see:bug/hardenPan
Aug 13, 2026
Merged

Harden panning via bound check#3899
dingodoppelt merged 1 commit into
jamulussoftware:mainfrom
ann0see:bug/hardenPan

Conversation

@ann0see

@ann0see ann0see commented Aug 13, 2026

Copy link
Copy Markdown
Member

Short description of changes

Bounds pan values to always be in range. In theory, the network values could have been any value. Thus bounding those is needed.

CHANGELOG: Bug: Ensure correct bounds for panning

Context: Fixes an issue?

No. Found by @mcfnord via AI review.

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Ready for review (fast review!)

What is missing until this pull request can be merged?

Review.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added this to Tracking Aug 13, 2026
@github-project-automation github-project-automation Bot moved this to Triage in Tracking Aug 13, 2026
@ann0see ann0see added bug Something isn't working backport_required A change to main that needs fix on an existing release. labels Aug 13, 2026
@ann0see ann0see moved this from Triage to Waiting on Team in Tracking Aug 13, 2026
@ann0see

ann0see commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

std::clamp would have been better - however, I believe it is not available unless we up the C++ version.

@ann0see
ann0see marked this pull request as ready for review August 13, 2026 17:28
@dingodoppelt

Copy link
Copy Markdown
Member

std::clamp would have been better - however, I believe it is not available unless we up the C++ version.

Ok, I have missed this. We use c++17 for some things already. Maybe this is an opportunity to up the version?

@ann0see

ann0see commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

Maybe this is an opportunity to up the version?

Not in this PR. Float2Short could then also be made easier I think. But again, not in this PR.

@ann0see ann0see added this to the Release 4.0.0 milestone Aug 13, 2026
Comment thread src/channel.cpp
@dingodoppelt
dingodoppelt merged commit 5146a07 into jamulussoftware:main Aug 13, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting on Team to Done in Tracking Aug 13, 2026
@ann0see
ann0see deleted the bug/hardenPan branch August 13, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport_required A change to main that needs fix on an existing release. bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants