ci: close Windows npm portability gap - #42
Open
jayzeng wants to merge 3 commits into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Windows GA path was under-tested in two places:
platform: win32while still using the host OS path implementation, so Linux could "verify" a non-native Windows path shapeagent-memory.cmdthat Windows npm users invokeWhat
path.win32on Windows andpath.posixelsewherepathmodulewindows-latestpackage smoke job that runs CLI tests,npm pack, installs the tarball into a clean prefix, verifies npm createdagent-memory.cmd, and executesagent-memory.cmd versionScope
No product/account/plugin behavior is added to MIT Core. The fixed external command handoff remains the only extension seam.
The private companion PR separately exercises the full Windows npm shim -> Core launcher -> native companion -> Core-version round trip, so this PR keeps Core's CI independent of private source.