Conversation
Pinning to 1.19.0 alone never exercises the strict RepoUrl/parse_hf_uri parsing (PR #4324, landed in 1.20.0) against Artifactory's commitUrl. Add 1.20.0 and 1.29.0 to the matrix as non-blocking (continue-on-error) canary jobs - they're expected to fail until jfrog/jfrog-cli-artifactory#548 merges and this repo's go.mod is bumped to pick up that fix, at which point they should be flipped back to gating. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
….0 fix jfrog/jfrog-cli-artifactory#548 merged (91bb546), fixing HfUriError handling for huggingface_hub >= 1.20.0. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
agrasth
marked this pull request as ready for review
September 21, 2026 10:10
Confirmed via manual workflow run against the bumped jfrog-cli-artifactory dependency: https://github.com/jfrog/jfrog-cli/actions/runs/35587298987 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bhanurp
self-requested a review
September 21, 2026 11:14
bhanurp
approved these changes
Sep 21, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hf_version: ['1.19.0', '1.20.0', '1.29.0']to theHuggingFace-Testsmatrix, so CI actually exercises huggingface_hub's stricterRepoUrl/parse_hf_uriparsing (upstream PR #4324, landed in 1.20.0) against Artifactory'scommitUrl, instead of only ever testing 1.19.0 (which predates the change).go.moddependency onjfrog-cli-artifactoryto include [PM Fixer] Fix huggingface 1.29.0 compatibility: swallow HfUriError from commitUrl parsing jfrog-cli-artifactory#548 (merged), which fixes handling of theHfUriErrorraised by that stricter parsing.continue-on-errorthat had been temporarily marking 1.20.0/1.29.0 as non-blocking - confirmed via manual runs that all three versions now pass on ubuntu/windows:Ready to merge.
🤖 Generated with Claude Code