fix: wrap month start/interval across year (#692) - #722
Open
arimu1 wants to merge 1 commit into
Open
Conversation
EveryFieldValueGenerator treated month "10/3" as only month 10 (from=start, to=12), so ExecutionTime skipped Jan/Apr/Jul. For MONTH + On/period, match months with year wrap via floorMod so 10/3 yields Oct, Jan, Apr, Jul. Non-month fields unchanged. Fixes jmrozanec#692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #692
ExecutionTimeonly returned the starting month for expressions like10/3(e.g. only October each year), skipping the rest of the every-N-months sequence (Jan/Apr/Jul).Cause
EveryFieldValueGeneratorforOn(start)/periodsetfrom = startandto = field end. For months that yields only values ≥ start that fit in 1–12, so10/3→{10}only.Fix
For the MONTH field with
start/period(On+ period), treat the progression as continuous across the year boundary using modular match:So
10/3→{1, 4, 7, 10}(Oct, Jan, Apr, Jul). Other fields (hours, minutes, …) keep non-wrapping behavior (22/3remains{22}).Reproduction (now fixed)
Test plan
Issue692Test— next/last/getExecutionDates + sequence for10/3EveryFieldValueGeneratorTest— month wrap candidates; hours22/3still non-wrapping