Replace Opentelemetry root with current to reuse existing trace. - #4002
Open
froque wants to merge 1 commit into
Open
Replace Opentelemetry root with current to reuse existing trace.#4002froque wants to merge 1 commit into
froque wants to merge 1 commit into
Conversation
Unit test shouldExtractFromHeadersAndCacheResultWhenNotAlreadyCached is not updated due to current() calling into root() internally.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4002 +/- ##
=========================================
Coverage 94.17% 94.18%
+ Complexity 6655 6654 -1
=========================================
Files 432 432
Lines 20893 20893
Branches 2096 2096
=========================================
+ Hits 19677 19678 +1
+ Misses 763 759 -4
- Partials 453 456 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit test shouldExtractFromHeadersAndCacheResultWhenNotAlreadyCached is not updated due to current() calling into root() internally.
Fixes #4001